gh-yzou commented on code in PR #1147:
URL: https://github.com/apache/polaris/pull/1147#discussion_r1996619844
##########
polaris-core/src/main/java/org/apache/polaris/core/entity/PolarisEntityType.java:
##########
@@ -32,9 +32,10 @@ public enum PolarisEntityType {
CATALOG_ROLE(5, CATALOG, true, false),
NAMESPACE(6, CATALOG, false, true),
// generic table is either a view or a real table
- TABLE_LIKE(7, NAMESPACE, false, false),
+ ICEBERG_TABLE_LIKE(7, NAMESPACE, false, false),
TASK(8, ROOT, false, false),
- FILE(9, TABLE_LIKE, false, false);
+ FILE(9, ICEBERG_TABLE_LIKE, false, false),
+ GENERIC_TABLE(10, NAMESPACE, false, false);
Review Comment:
If we all think have an entity type fits with the Polaris design better, I
am also good on this.
@sfc-gh-ygu in terms of your question about privilege, today's privilege is
defined with entity type + subtype, not sure if we can add another layer on top
of the entity type, but we can definitely extend how privilege is defined to
take not just one entity type + subtype.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
