eric-maynard commented on code in PR #1147:
URL: https://github.com/apache/polaris/pull/1147#discussion_r1987736655
##########
polaris-core/src/main/java/org/apache/polaris/core/entity/IcebergTableLikeEntity.java:
##########
@@ -24,7 +24,7 @@
import org.apache.iceberg.catalog.TableIdentifier;
import org.apache.iceberg.rest.RESTUtil;
-public class TableLikeEntity extends PolarisEntity {
+public class IcebergTableLikeEntity extends PolarisEntity {
// For applicable types, this key on the "internalProperties" map will
return the location
// of the internalProperties JSON file.
public static final String METADATA_LOCATION_KEY = "metadata-location";
Review Comment:
This is the reason that we don't just make GENERIC a subType of TABLE_LIKE
-- TABLE_LIKE assumes a metadata location (among other things), and we probably
don't want to bake that assumption into generic tables. Beyond that, this leads
us to refactors in resolution that should set the stage for volumes which would
have a similar problem as generic tables.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
