gh-yzou commented on code in PR #1126:
URL: https://github.com/apache/polaris/pull/1126#discussion_r2004556233
##########
integration-tests/src/main/java/org/apache/polaris/service/it/test/PolarisRestCatalogIntegrationTest.java:
##########
@@ -234,24 +250,14 @@ public void before(TestInfo testInfo) {
extraPropertiesBuilder.put(config.value()[i], config.value()[i +
1]);
}
});
-
- restCatalog =
- IcebergHelper.restCatalog(
- client,
- endpoints,
- principalCredentials,
- currentCatalogName,
- extraPropertiesBuilder.build());
- }
-
- @AfterEach
- public void cleanUp() {
- client.cleanUp(adminCredentials);
- }
-
- @Override
- protected RESTCatalog catalog() {
- return restCatalog;
+ extraPropertiesBuilder.putAll(additionalProperties);
+ return IcebergHelper.restCatalog(
+ client,
+ endpoints,
+ principalCredentials,
+ catalogName,
+ currentCatalogName,
Review Comment:
for this I think you should do similar thing as what you have done for the
other tests, the initCatalog should also initialize the the catalog with the
service first, otherwise, we may not be testing the right thing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
