gh-yzou commented on code in PR #1126:
URL: https://github.com/apache/polaris/pull/1126#discussion_r2004561555


##########
quarkus/service/src/test/java/org/apache/polaris/service/quarkus/catalog/IcebergCatalogTest.java:
##########
@@ -318,6 +285,52 @@ protected IcebergCatalog catalog() {
     return catalog;
   }
 
+  @Override
+  protected IcebergCatalog initCatalog(
+      String catalogName, Map<String, String> additionalProperties) {

Review Comment:
   Can you add a comment here about what it the initCatalog function is doing. 
so that the purpose is more clear. For example, 
   ```
   this function crates a catalog with the given catalogName with the Polaris 
service, and returns an IcebergCatalog object.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to