dimas-b commented on code in PR #1126:
URL: https://github.com/apache/polaris/pull/1126#discussion_r2004557916
##########
quarkus/service/src/test/java/org/apache/polaris/service/quarkus/catalog/IcebergCatalogTest.java:
##########
@@ -153,6 +153,8 @@ public Map<String, String> getConfigOverrides() {
"true",
"polaris.features.defaults.\"INITIALIZE_DEFAULT_CATALOG_FILEIO_FOR_TEST\"",
"true",
+ "polaris.features.defaults.\"ALLOW_OVERLAPPING_CATALOG_URLS\"",
+ "true",
Review Comment:
Why do we need this with Iceberg 1.8 when we did not need it with 1.7?
##########
integration-tests/src/main/java/org/apache/polaris/service/it/env/IcebergHelper.java:
##########
@@ -53,11 +54,11 @@ public static RESTCatalog restCatalog(
.put(
org.apache.iceberg.CatalogProperties.FILE_IO_IMPL,
"org.apache.iceberg.inmemory.InMemoryFileIO")
- .put("warehouse", catalog)
+ .put("warehouse", warehouse)
.put("header." + endpoints.realmHeaderName(), endpoints.realmId())
.putAll(extraProperties);
- restCatalog.initialize("polaris", propertiesBuilder.buildKeepingLast());
+ restCatalog.initialize(catalog, propertiesBuilder.buildKeepingLast());
Review Comment:
AFAIK, the internal `name` of `RESTCatalog` is relevant only on the client
side. I do not see a reason to customize it for tests.
"warehouse" maps to the server-side Polaris catalog name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
