liamzwbao commented on code in PR #1126:
URL: https://github.com/apache/polaris/pull/1126#discussion_r2006737111


##########
quarkus/service/src/test/java/org/apache/polaris/service/quarkus/catalog/IcebergCatalogTest.java:
##########
@@ -153,6 +153,8 @@ public Map<String, String> getConfigOverrides() {
           "true",
           
"polaris.features.defaults.\"INITIALIZE_DEFAULT_CATALOG_FILEIO_FOR_TEST\"",
           "true",
+          "polaris.features.defaults.\"ALLOW_OVERLAPPING_CATALOG_URLS\"",
+          "true",

Review Comment:
   This is related to the test 
[testCatalogWithCustomMetricsReporter](https://github.com/apache/iceberg/blob/58b283e3533afce8b9884ac847a46eb40688353b/core/src/test/java/org/apache/iceberg/catalog/CatalogTests.java#L2936)
 added in 1.8, it `initCatalog` inside the test which causes the following 
error.  
   ```
   org.apache.iceberg.exceptions.ValidationException: Cannot create Catalog 
catalog_with_custom_reporter. One or more of its locations overlaps with an 
existing catalog
   ```
   I tried to add catalog name to the `allowedLocations` to avoid overlapping, 
but some Iceberg tests require `allowedLocations` to contain 
`file:/tmp/ns/table` which is hardcoded and cannot prefix with catalog name or 
UUID.
   
   Would appreciate any suggestions or alternative solutions.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to