gh-yzou commented on code in PR #1231:
URL: https://github.com/apache/polaris/pull/1231#discussion_r2013121486
##########
polaris-core/src/main/java/org/apache/polaris/core/entity/PolarisEntitySubType.java:
##########
@@ -30,8 +30,9 @@ public enum PolarisEntitySubType {
ANY_SUBTYPE(-1, null),
// the NULL value is used when an entity has no subtype, i.e. NOT_APPLICABLE
really
NULL_SUBTYPE(0, null),
- TABLE(2, PolarisEntityType.ICEBERG_TABLE_LIKE),
- VIEW(3, PolarisEntityType.ICEBERG_TABLE_LIKE);
+ ICEBERG_TABLE(2, PolarisEntityType.TABLE_LIKE),
+ VIEW(3, PolarisEntityType.TABLE_LIKE),
Review Comment:
Shall we just call this ICEBEG_VIEW to be consistent on the naming, I don't
think we can reuse this for regular views if we support that in the future
##########
polaris-core/src/main/java/org/apache/polaris/core/entity/table/IcebergTableLikeEntity.java:
##########
@@ -82,7 +75,7 @@ public String getBaseLocation() {
public static class Builder extends
PolarisEntity.BaseBuilder<IcebergTableLikeEntity, Builder> {
public Builder(TableIdentifier identifier, String metadataLocation) {
super();
- setType(PolarisEntityType.ICEBERG_TABLE_LIKE);
+ setType(PolarisEntityType.TABLE_LIKE);
Review Comment:
One quick question here, where would the subtype for the ICEBERG_TABLE OR
VIEW set? I see for generic table it is set during build
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
