eric-maynard commented on code in PR #1231:
URL: https://github.com/apache/polaris/pull/1231#discussion_r2013371996
##########
service/common/src/main/java/org/apache/polaris/service/catalog/generic/GenericTableCatalog.java:
##########
@@ -97,10 +101,9 @@ public void createGenericTable(
List<PolarisEntity> catalogPath = resolvedParent.getRawFullPath();
- // TODO we need to filter by type here?
PolarisResolvedPathWrapper resolvedEntities =
resolvedEntityView.getPassthroughResolvedPath(
- tableIdentifier, PolarisEntityType.GENERIC_TABLE,
PolarisEntitySubType.ANY_SUBTYPE);
+ tableIdentifier, PolarisEntityType.TABLE_LIKE,
PolarisEntitySubType.ANY_SUBTYPE);
Review Comment:
From talking to @dennishuo, I think it was in fact making multiple trips. To
solve that and also address your comment, I have refactored the view check a
bit to include generic tables. Let me know what you think!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
