MonkeyCanCode opened a new pull request, #1610: URL: https://github.com/apache/polaris/pull/1610
This PR fixes couple issues found while trying to go through quick-start guide: 1. Doc `site/content/in-dev/unreleased/getting-started/quickstart.md` has an invalid ref to `getting-started/eclipselink/docker-compose-postgres.yml`. This is updated to `getting-started/assets/postgres/docker-compose-postgres.yml` (this is correct in `getting-started/eclipselink/README.md` but not in the public page) 2. Due to now we have 3 docker compose and 1 in a diff path, running this command can cause failure as they 2 of them have binds from local to container. The bind from local to container is relative to the current directory of the user (however, the docker-compose is using relative path which is not correct and causing failures). To fix this, I introduced `ASSETS_PATH` to point to the path of assets directory which is being used for binding. 3. Doc `getting-started/eclipselink/docker-compose-bootstrap-db.yml` has a hard-coded value of default username/password which is no longer valid after recent change in https://github.com/apache/polaris/pull/1522 4. quickstart page (https://polaris.apache.org/in-dev/unreleased/getting-started/quickstart/#docker-image) ask user to build the image then run docker compose and asks user to do expose `CLIENT_ID` and `CLIENT_SECRET`. Due to change in item 3, that is no longer valid as default value are not longer available. This will cause failure as well. To fix this, I add `.env` file to contain the original default value. This will continue to allow user to set them to diff by remove env loading for docker compose. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
