adnanhemani commented on code in PR #1610:
URL: https://github.com/apache/polaris/pull/1610#discussion_r2096694571
##########
getting-started/eclipselink/docker-compose.yml:
##########
@@ -82,7 +82,7 @@ services:
--conf, "spark.sql.catalog.quickstart_catalog.type=rest",
--conf,
"spark.sql.catalog.quickstart_catalog.warehouse=quickstart_catalog",
--conf,
"spark.sql.catalog.quickstart_catalog.uri=http://polaris:8181/api/catalog";,
- --conf,
"spark.sql.catalog.quickstart_catalog.credential=${USER_CLIENT_ID}:${USER_CLIENT_SECRET}",
+ --conf,
"spark.sql.catalog.quickstart_catalog.credential=${CLIENT_ID}:${CLIENT_SECRET}",
Review Comment:
This is a regression, it should remain USER_CLIENT_ID/SECRET - these are
user credentials rather than the admin credentials in CLIENT_ID/SECRET
##########
site/content/in-dev/unreleased/getting-started/quickstart.md:
##########
@@ -36,7 +36,8 @@ cd ~/polaris
:polaris-quarkus-admin:assemble --rerun \
-Dquarkus.container-image.tag=postgres-latest \
-Dquarkus.container-image.build=true
-docker compose -f getting-started/eclipselink/docker-compose-postgres.yml -f
getting-started/eclipselink/docker-compose-bootstrap-db.yml -f
getting-started/eclipselink/docker-compose.yml up
+export ASSETS_PATH=$(pwd)/getting-started/assets/
Review Comment:
Can we move this line to the top of the file with the exporting of the
CLIENT_ID/SECRET, so that it only needs to be run once?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
