HonahX commented on code in PR #1628:
URL: https://github.com/apache/polaris/pull/1628#discussion_r2098969095


##########
extension/persistence/jpa-model/src/main/java/org/apache/polaris/jpa/models/ModelPolicyMappingRecord.java:
##########
@@ -33,7 +33,7 @@
     indexes = {
       @Index(
           name = "POLICY_MAPPING_RECORDS_BY_POLICY_INDEX",
-          columnList = "policyCatalogId,policyId,targetCatalogId,targetId")
+          columnList = 
"policyTypeCode,policyCatalogId,policyId,targetCatalogId,targetId")

Review Comment:
   Since policy support is already available in EclipseLink and this PR 
introduces only a minor change ahead of the 1.0 release, I think it's 
reasonable to include it. My understanding is that we don’t plan to add any 
major new features to EclipseLink moving forward.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to