dimas-b commented on code in PR #1628:
URL: https://github.com/apache/polaris/pull/1628#discussion_r2103148029
##########
polaris-core/src/main/java/org/apache/polaris/core/policy/TransactionalPolicyMappingPersistence.java:
##########
@@ -54,7 +54,7 @@ default void deleteFromPolicyMappingRecordsInCurrentTxn(
/** See {@link PolicyMappingPersistence#deleteAllEntityPolicyMappingRecords}
*/
default void deleteAllEntityPolicyMappingRecordsInCurrentTxn(
@Nonnull PolarisCallContext callCtx,
- @Nonnull PolarisEntityCore entity,
+ @Nonnull PolarisBaseEntity entity,
Review Comment:
side note: we should probably review the `PolarisEntityCore` type hierarchy.
`PolarisBaseEntity` dominates all child types, so it can probably be folded
into `PolarisEntityCore` (or the other way around).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
