singhpk234 commented on code in PR #1628:
URL: https://github.com/apache/polaris/pull/1628#discussion_r2103354934
##########
extension/persistence/relational-jdbc/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc/QueryGenerator.java:
##########
@@ -60,23 +64,20 @@ public static String
generateDeleteQueryForEntityGrantRecords(
}
public static String generateDeleteQueryForEntityPolicyMappingRecords(
- @Nonnull PolarisEntityCore entity, @Nonnull String realmId) {
- String targetCondition =
- String.format(
- "target_id = %s AND target_catalog_id = %s", entity.getId(),
entity.getCatalogId());
- String sourceCondition =
- String.format(
- "policy_id = %s AND policy_catalog_id = %s", entity.getId(),
entity.getCatalogId());
+ @Nonnull PolarisBaseEntity entity, @Nonnull String realmId) {
+ Map<String, Object> objMap = new HashMap<>();
Review Comment:
[minor] I would go for `queryParams`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
