flyrain commented on code in PR #1628:
URL: https://github.com/apache/polaris/pull/1628#discussion_r2101138668
##########
extension/persistence/eclipselink/src/main/java/org/apache/polaris/extension/persistence/impl/eclipselink/PolarisEclipseLinkMetaStoreSessionImpl.java:
##########
@@ -703,7 +703,7 @@ public void deleteFromPolicyMappingRecordsInCurrentTxn(
@Override
public void deleteAllEntityPolicyMappingRecordsInCurrentTxn(
@Nonnull PolarisCallContext callCtx,
- @Nonnull PolarisEntityCore entity,
+ @Nonnull PolarisBaseEntity entity,
Review Comment:
Not a blocker: I feel like these two classes are interchangeable in Polaris.
Can we merge them to avoid any type mismatching like this? cc @dennishuo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
