flyrain commented on code in PR #2473:
URL: https://github.com/apache/polaris/pull/2473#discussion_r2310619315
##########
polaris-core/src/main/java/org/apache/polaris/core/storage/PolarisStorageConfigurationInfo.java:
##########
@@ -160,7 +161,7 @@ public static Optional<PolarisStorageConfigurationInfo>
forEntityPath(
Set<String> locations =
StorageUtil.getLocationsAllowedToBeAccessed(
null, entityPathReversed.get(0).getPropertiesAsMap());
- return new StorageConfigurationOverride(
+ return new LocationRestrictions(
Review Comment:
Test `createViewWithCustomMetadataLocationUsingPolaris()` failed once we
remove it, which was introduced by #1320. Do we need to support view with
custom location(`write.metadata.path`)? I don't think it's necessary. We can
probably revert all changes in #1320 if needed. Also, we can fix it in a
followup PR. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
