dennishuo commented on code in PR #2473:
URL: https://github.com/apache/polaris/pull/2473#discussion_r2309271707
##########
polaris-core/src/main/java/org/apache/polaris/core/storage/PolarisStorageConfigurationInfo.java:
##########
@@ -160,7 +161,7 @@ public static Optional<PolarisStorageConfigurationInfo>
forEntityPath(
Set<String> locations =
StorageUtil.getLocationsAllowedToBeAccessed(
null, entityPathReversed.get(0).getPropertiesAsMap());
- return new StorageConfigurationOverride(
+ return new LocationRestrictions(
Review Comment:
I think the TODO on line 160 added in
https://github.com/apache/polaris/pull/1320/files#diff-607cdd8c6ea78443988359e42ffec3091a4c84bc9151575772ee3b90164e03f3
was correctly pointing out that the addition of these locations from
`StorageUtil.getLocationsAllowedToBeAccessed` (formerly
`userSpecifiedWriteLocations`) msimatched the intent of the validation in ways
that were problematic for Views.
We should remove all this location-augmentation here and simply return the
basic restrictions directly from `configInfo` in this `else` branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
