eric-maynard commented on code in PR #2473:
URL: https://github.com/apache/polaris/pull/2473#discussion_r2310892168
##########
polaris-core/src/main/java/org/apache/polaris/core/storage/PolarisStorageConfigurationInfo.java:
##########
@@ -160,7 +161,7 @@ public static Optional<PolarisStorageConfigurationInfo>
forEntityPath(
Set<String> locations =
StorageUtil.getLocationsAllowedToBeAccessed(
null, entityPathReversed.get(0).getPropertiesAsMap());
- return new StorageConfigurationOverride(
+ return new LocationRestrictions(
Review Comment:
I don't think we need to worry too much about edge cases like a custom
`write.metadata.path` for views. In fact, even for tables, we all know that
tables can contain data files outside of `write.metadata.path` U
`write.data.path` U `location` right? We need to capture the majority of use
layouts with credential vending, but not necessarily the long tail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
