flyrain commented on code in PR #2473:
URL: https://github.com/apache/polaris/pull/2473#discussion_r2311336380
##########
integration-tests/src/main/java/org/apache/polaris/service/it/test/PolarisRestCatalogViewIntegrationBase.java:
##########
@@ -201,16 +201,10 @@ public void
createViewWithCustomMetadataLocationUsingPolaris(@TempDir Path tempD
TableIdentifier identifier = TableIdentifier.of("ns", "view");
String location = Paths.get(tempDir.toUri().toString()).toString();
- String customLocation = Paths.get(tempDir.toUri().toString(),
"custom-location").toString();
- String customLocation2 = Paths.get(tempDir.toUri().toString(),
"custom-location2").toString();
- String customLocationChild =
- Paths.get(tempDir.toUri().toString(),
"custom-location/child").toString();
+ String customLocation =
+ Paths.get(storageConfig.getAllowedLocations().getFirst(),
"/custom-location1").toString();
- catalog()
- .createNamespace(
- identifier.namespace(),
- ImmutableMap.of(
-
IcebergTableLikeEntity.USER_SPECIFIED_WRITE_METADATA_LOCATION_KEY, location));
Review Comment:
It doesn't make sense to have a `write.metadata.path` for namespace, also we
won't check the locations used by parent after the change in method
`forEntityPath`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
