dennishuo commented on code in PR #2473:
URL: https://github.com/apache/polaris/pull/2473#discussion_r2311632479


##########
integration-tests/src/main/java/org/apache/polaris/service/it/test/PolarisRestCatalogViewIntegrationBase.java:
##########
@@ -201,16 +201,10 @@ public void 
createViewWithCustomMetadataLocationUsingPolaris(@TempDir Path tempD
     TableIdentifier identifier = TableIdentifier.of("ns", "view");
 
     String location = Paths.get(tempDir.toUri().toString()).toString();

Review Comment:
   The base class does add the `@TempDir` to allowedLocations in 
https://github.com/apache/polaris/blob/f555f30f6f6a10df441e8da84098c82245de28a9/integration-tests/src/main/java/org/apache/polaris/service/it/test/PolarisRestCatalogViewFileIntegrationTestBase.java#L43
   
   Is this a different tempdir that escapes? If we want to exercise a failure 
we probably need to try to set the `location` to something else.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to