flyrain commented on code in PR #2629:
URL: https://github.com/apache/polaris/pull/2629#discussion_r2369771545


##########
runtime/service/src/main/java/org/apache/polaris/service/events/listeners/PolarisEventListener.java:
##########
@@ -29,287 +29,287 @@
  * Represents an event listener that can respond to notable moments during 
Polaris's execution.
  * Event details are documented under the event objects themselves.
  */
-public abstract class PolarisEventListener {
+public interface PolarisEventListener {

Review Comment:
   Looking over the PR, it looks like all methods are now default methods, 
which is fine. Let's also ensure that any new methods added in the future are 
default as well.
   
   Could we add a test to enforce this? It might also be helpful to include a 
comment on the class to explicitly state that all new methods should be default.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to