adutra commented on code in PR #2629:
URL: https://github.com/apache/polaris/pull/2629#discussion_r2372932409


##########
runtime/service/src/main/java/org/apache/polaris/service/events/listeners/PolarisEventListener.java:
##########
@@ -29,287 +29,287 @@
  * Represents an event listener that can respond to notable moments during 
Polaris's execution.
  * Event details are documented under the event objects themselves.
  */
-public abstract class PolarisEventListener {
+public interface PolarisEventListener {

Review Comment:
   Added a comment and tests as suggested.
   
   I also re-organized the interface methods into "sections" for clarity, I 
hope that's OK.
   
   The tests check that all methods are default and well-formed, and also that 
all events have corresponding methods in the interface. 
   
   I added a similar check to `TestPolarisEventListener` (it was lacking many 
methods).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to