adutra commented on code in PR #2629:
URL: https://github.com/apache/polaris/pull/2629#discussion_r2372777090
##########
runtime/service/src/main/java/org/apache/polaris/service/events/listeners/PolarisEventListener.java:
##########
@@ -29,287 +29,287 @@
* Represents an event listener that can respond to notable moments during
Polaris's execution.
* Event details are documented under the event objects themselves.
*/
-public abstract class PolarisEventListener {
+public interface PolarisEventListener {
Review Comment:
Hi @flyrain thanks for your flexibility 🙂
I will add the comment and the test as suggested.
I'd note that this kind of check would be a good fit for the `revapi` plugin
– the same one we use in Iceberg to track API breaking changes. But I think
Polaris is still a young project, and revapi would flag too many API changes
that would be otherwise permitted by our current evolution rules:
https://github.com/apache/polaris/blob/b1eb9bd81da10b8cc7bb3f200ceb22b9990642bb/site/content/in-dev/unreleased/evolution.md?plain=1#L81-L82
So, let's stick with a small test for now 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
