adutra commented on code in PR #2629:
URL: https://github.com/apache/polaris/pull/2629#discussion_r2372935231


##########
runtime/service/src/main/java/org/apache/polaris/service/admin/PolarisCatalogsEventServiceDelegator.java:
##########
@@ -91,9 +91,9 @@ public Response updateCatalog(
 
   @Override
   public Response listCatalogs(RealmContext realmContext, SecurityContext 
securityContext) {
-    polarisEventListener.onBeforeListCatalog(new 
CatalogsServiceEvents.BeforeListCatalogEvent());
+    polarisEventListener.onBeforeListCatalogs(new 
CatalogsServiceEvents.BeforeListCatalogsEvent());

Review Comment:
   When I added tests for method compliance I noticed that this event was 
different from other "list" events because the object type being listed wasn't 
in the plural.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to