HonahX commented on code in PR #2643:
URL: https://github.com/apache/polaris/pull/2643#discussion_r2400411973
##########
client/python/cli/command/profiles.py:
##########
@@ -104,6 +110,8 @@ def _update_profile(self, name: str) -> None:
current_client_secret = profiles[name].get("client_secret")
current_host = profiles[name].get("host")
current_port = profiles[name].get("port")
+ current_realm = profiles[name].get(Arguments.REALM)
Review Comment:
+1 on using constants instead of pure string. I think this shall be a good
practice in the future .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
