eric-maynard commented on code in PR #2643:
URL: https://github.com/apache/polaris/pull/2643#discussion_r2400455361
##########
client/python/cli/options/parser.py:
##########
@@ -55,26 +55,25 @@ class Parser(object):
str,
hint="access token for token-based authentication",
),
+ Argument(
+ Arguments.REALM,
+ str,
+ hint="realm to use with header. if not defined will be used
default realm from Polaris server. read more:
https://polaris.apache.org/releases/1.1.0/configuration/";,
+ default=None
+ ),
+ Argument(
+ Arguments.HEADER,
Review Comment:
To add more color here, the way you would use `--header` to achieve a custom
realm would be either like `--header "Polaris-Realm: foo"` or `--header
"My-Custom-Realm-Header-Name: bar"`. This supports custom realm header names
without the need to introduce a flag specifically for that.
The current implementation is sort of the worst of both worlds, because we
have added a generic-sounding `header` flag that actually does something really
specific to just one type of header.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
