jbonofre commented on code in PR #2643:
URL: https://github.com/apache/polaris/pull/2643#discussion_r2393539750
##########
client/python/cli/command/profiles.py:
##########
@@ -72,11 +74,15 @@ def _create_profile(self, name: str) -> None:
client_secret = input("Polaris Client Secret: ")
host = input(f"Polaris Host [{DEFAULT_HOSTNAME}]: ") or
DEFAULT_HOSTNAME
port = input(f"Polaris Port [{DEFAULT_PORT}]: ") or DEFAULT_PORT
+ realm = input(f"Polaris Context Realm: ")
+ header = input(f"Polaris Context Header Name [{DEFAULT_HEADER}]:
") or DEFAULT_HEADER
profiles[name] = {
"client_id": client_id,
"client_secret": client_secret,
"host": host,
"port": port,
+ Arguments.REALM: realm,
Review Comment:
Just curious (nit): why using a different syntax here ? Why not using
directly `realm` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
