binarycat0 commented on code in PR #2643:
URL: https://github.com/apache/polaris/pull/2643#discussion_r2401172532
##########
client/python/generate_clients.py:
##########
@@ -164,7 +164,7 @@ def generate_polaris_catalog_client() -> None:
"-g",
"python",
"-o",
- CLIENT_DIR,
+ str(CLIENT_DIR),
Review Comment:
Hello. Yes, I did face an issue with impossibility to execute generating
specs in case of incorrectness of types, cause I assume `__repr__` method of
CLIENT_DIR object returns not string but PosixPath object.
```
Traceback (most recent call last):
File "/polaris/client/python/generate_clients.py", line 328, in <module>
main()
File "/polaris/client/python/generate_clients.py", line 324, in main
build()
File "/polaris/client/python/generate_clients.py", line 303, in build
generate_polaris_management_client()
File "/polaris/client/python/generate_clients.py", line 133, in
generate_polaris_management_client
subprocess.check_call(
File "/usr/lib/python3.12/subprocess.py", line 413, in check_call
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['openapi-generator-cli',
'generate', '-i', '/polaris/client/python/spec/polaris-management-service.yml',
'-g', 'python', '-o', PosixPath('/polaris/client/python'),
'--additional-properties=packageName=polaris.management',
'--additional-properties=apiNamePrefix=polaris',
'--additional-properties=pythonVersion=3.9',
'--additional-properties=generateSourceCodeOnly=true', '--skip-validate-spec',
'--ignore-file-override', '/polaris/client/python/.openapi-generator-ignore',
'--global-property=apiDocs=false,modelDocs=false,modelTests=false,apiTests=false']'
returned non-zero exit status 1.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
