flyrain commented on code in PR #2784:
URL: https://github.com/apache/polaris/pull/2784#discussion_r2421335082


##########
polaris-core/src/main/java/org/apache/polaris/core/config/FeatureConfiguration.java:
##########
@@ -429,4 +429,13 @@ public static void enforceFeatureEnabledOrThrow(
               "When true, enables finer grained update table privileges which 
are passed to the authorizer for update table operations")
           .defaultValue(true)
           .buildFeatureConfiguration();
+
+  public static final FeatureConfiguration<Boolean> 
ALLOW_FEDERATED_CATALOGS_CREDENTIAL_VENDING =

Review Comment:
   I'm still a bit confused by the long-term need of this config. Taking 
`passthrough-facade EXTERNAL catalog` as an example, why do we need a config to 
control the behavior? It should be the default behavior. Or is there any use 
case that user don't want a credential vending, but still config the storage 
info.?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to