dimas-b commented on code in PR #2784:
URL: https://github.com/apache/polaris/pull/2784#discussion_r2417754626
##########
runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogHandler.java:
##########
@@ -808,7 +809,10 @@ private LoadTableResponse.Builder
buildLoadTableResponseWithDelegationCredential
PolarisResolvedPathWrapper resolvedStoragePath =
CatalogUtils.findResolvedStorageEntity(resolutionManifest,
tableIdentifier);
- if (baseCatalog instanceof IcebergCatalog && resolvedStoragePath != null) {
+ if ((baseCatalog instanceof IcebergCatalog
+ || realmConfig.getConfig(
+ ALLOW_EXTERNAL_CATALOG_CREDENTIAL_VENDING,
getResolvedCatalogEntity()))
Review Comment:
The `ALLOW_EXTERNAL_CATALOG_CREDENTIAL_VENDING` flag exists since #395. I
believe we ought to inform users that existing flags start altering Polaris
behaviour in new areas (where they did not work before).
Note that the default for `ALLOW_EXTERNAL_CATALOG_CREDENTIAL_VENDING` is
`true`, so all users who have catalogs that are not `instanceof IcebergCatalog`
will be affected by this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
