singhpk234 commented on PR #3207: URL: https://github.com/apache/polaris/pull/3207#issuecomment-3628655628
Apologies @dimas-b but i am unable to understand the rush of getting these NoSQL huge PRs in and not giving community **apporpriate** time to review the code, I am strongly concerned about this, this pr is ~7k LOC the diff is so huge that it doesn't even render in github UI This PR was raised ~4 days ago of which 2 days were weekend and i was reviewing these changes considering i have appropriate time, but i just open the github to see it was approved 7k LOC merged in less than a minute after approval, even when it had been called out the NoSQL impl is not following the practice we have already in the Polaris : - https://github.com/apache/polaris/pull/3135#discussion_r2558515915 <img width="978" height="914" alt="Screenshot 2025-12-08 at 9 06 23 AM" src="https://github.com/user-attachments/assets/abcfe64e-50bd-4333-93aa-2fbd6274f5d7"; /> I request to please give more set eyes to get this massive code changes in. cc @jbonofre @dennishuo @flyrain @collado-mike -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
