dimas-b commented on PR #3207: URL: https://github.com/apache/polaris/pull/3207#issuecomment-3628736284
@singhpk234 : I welcome you interest in the NoSQL Persistence code. The more developers get involved, the better code quality will be, I'm sure. At to your specific points, the [current guildelines](https://github.com/apache/polaris/blob/07dd8ef0b9cb9a8349750594ae76a3d870186538/CONTRIBUTING.md?plain=1#L145) indicate "two working days" as a reasonable time period for providing initial PR comments. As for "rush", recent NoSQL PR basically chip off small code chunks from #1189, which has been available for interested parties to review for many months now (and some community members do have hands-on experience with it). It is in "draft" only to indicate that is it not meant to be merged whole, but it was mentioned in the original NoSQL [proposal](https://lists.apache.org/thread/s1v7svrbvq7y4gt3lm88y79td58o644x) in March 2025 and multiple online meetings (IIRC). AFAIK, the community is in general agreement on accepting the NoSQL Persistence contribution. These changes are isolated from the rest of the Polaris codebase and do not affect any existing code paths, as far as I can tell. However, if you or someone have specific concerns about the new code after merging, by all means, let's discuss on the `dev` ML. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
