singhpk234 commented on PR #3207: URL: https://github.com/apache/polaris/pull/3207#issuecomment-3628980559
@dimas-b, current guidelines just says about first round of comments and not when to merge, orthogonally, nevertheless we all agree that the current guidelines needs some refinement and hence we as a community we are working towards defining new one : https://github.com/apache/polaris/pull/3067 and i strongly think LOC should be factor on this. >AFAIK, the community is in general agreement on accepting the NoSQL Persistence contribution The community has recently expressed their concerns about what NoSQL meeting (12/2) i believe we all were there : dev list : https://lists.apache.org/thread/t6ddtgk0wt92opphvy0o6lvx8pjk0go8 video ref : https://drive.google.com/file/d/1r_7bPtQEp7jdB1gtP15KvC_qLE6271Rf/view - the main questions why do we need to support all backend, why do we need to make yet another iceberg on top of database. - severe perf consideration and req to benchmark 1 catalog with 100k table with concurrent update randomly happening in any of the table but instead of adressing them, that we are adding more and more code, i am unclear what happened to the things we discussed in the meeting are they just lost or they not considered concerns. At this point of time i don't think there is a concencus on NoSQL approach second we had the mentor @fpapon of the project addiontally suggested we need minimum of 2 approvers in thread here : https://lists.apache.org/thread/hzxds729v5r68togbfx76l14f9m4bfj4 I am unsure starting a new ML to call this out is gonna make any difference if the above ones didn't. I request again please give appropriate time for review, with the screenshot i wanted to share is i was indeed review (I know its only visible to me) but the review was not given appropriate time, before i could publish and if we would have just give some time post your approval, I would have got notification that this PR is about to merge i need to publish my review even if its half baked, but in one minute it got merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
