MonkeyCanCode commented on code in PR #4393:
URL: https://github.com/apache/polaris/pull/4393#discussion_r3214418688
##########
regtests/t_pyspark/src/conftest.py:
##########
@@ -101,37 +101,30 @@ def catalog_client(polaris_catalog_url):
host=polaris_catalog_url))
return IcebergCatalogAPI(client)
-
@pytest.fixture
def snowflake_catalog(root_client, catalog_client, test_bucket, aws_role_arn,
aws_bucket_base_location_prefix):
- minio_test_enabled_raw = os.getenv('MINIO_TEST_ENABLED', '')
- if minio_test_enabled_raw == '':
- # Auto-detect based on whether AWS tests are enabled
- aws_test_enabled = os.getenv('AWS_TEST_ENABLED', 'false').lower() == 'true'
- minio_enabled = not aws_test_enabled
- else:
- minio_enabled = minio_test_enabled_raw.lower() == 'true'
-
- if minio_enabled:
- # MinIO mode: use MinIO's STS endpoint for credential vending
- minio_endpoint = os.getenv('MINIO_ENDPOINT', 'http://minio:9000')
+ s3_backend = os.getenv('S3_TEST_BACKEND', '').lower()
Review Comment:
Actually, this is not needed. Part of the refactor that I missed to cleanup.
As I am checking os environ directly within `@pytest.mark.skipif`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
