MonkeyCanCode commented on code in PR #4393:
URL: https://github.com/apache/polaris/pull/4393#discussion_r3214422757
##########
regtests/t_pyspark/src/test_spark_sql_s3_with_privileges.py:
##########
@@ -256,9 +256,9 @@ def reader_catalog_client(polaris_catalog_url, reader):
host=polaris_catalog_url)))
[email protected](os.environ.get('AWS_TEST_ENABLED', 'False').lower() !=
'true' and
- os.environ.get('MINIO_TEST_ENABLED', 'false').lower() !=
'true',
- reason='AWS_TEST_ENABLED or MINIO_TEST_ENABLED is not set
or is false')
[email protected](os.environ.get('AWS_TEST_ENABLED', 'False').lower() !=
'true' and not
+ os.environ.get('S3_TEST_ENABLED') in ['minio', 'rustfs'],
Review Comment:
Good patch on this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
