MonkeyCanCode commented on code in PR #4393:
URL: https://github.com/apache/polaris/pull/4393#discussion_r3230471935
##########
regtests/run.sh:
##########
@@ -65,27 +65,30 @@ export PYTHONDONTWRITEBYTECODE=1
NUM_FAILURES=0
NUM_SUCCESSES=0
-# Detect test mode: AWS or MinIO
-if [ -z "${MINIO_TEST_ENABLED}" ]; then
- # Auto-detect: use MinIO if AWS tests not enabled
+# Determine test mode (default to MinIO for local S3)
+if [ -z "${S3_TEST_BACKEND}" ]; then
+ # Use MinIO as the default local backend if AWS tests are not enabled
if [ "${AWS_TEST_ENABLED}" == "true" ]; then
- export MINIO_TEST_ENABLED=false
+ export S3_TEST_BACKEND=aws
loginfo "AWS tests enabled, using AWS mode"
else
- export MINIO_TEST_ENABLED=true
+ export S3_TEST_BACKEND=minio
export AWS_TEST_ENABLED=false
- loginfo "AWS tests not enabled, enabling MinIO mode"
+ loginfo "AWS tests not enabled, defaulting to MinIO mode"
Review Comment:
yes, I was tried to minimize the changes as original code is using
AWS_TEST_ENABLED and MINIO_TEST_ENABLED. But I think you are right which we can
just do S3_TEST_BACKEND and have 3 diff values to support aws, minio, and
rustfs which will make the selection logic a lot simpler. I will refactor this
later tonight.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
