MonkeyCanCode commented on code in PR #4393:
URL: https://github.com/apache/polaris/pull/4393#discussion_r3214434241
##########
regtests/docker-compose.yml:
##########
@@ -17,18 +17,46 @@
# under the License.
#
+x-aws-client-creds: &aws-client-creds
+ AWS_ACCESS_KEY_ID: ${S3_ACCESS_KEY:-polarisadmin}
+ AWS_SECRET_ACCESS_KEY: ${S3_SECRET_KEY:-polarisadmin}
+ AWS_REGION: us-west-2
+
services:
minio:
image: minio/minio:latest
+ profiles: ["minio"]
ports:
- "9000:9000"
- "9001:9001"
+ networks:
+ default:
+ aliases:
+ - s3.local
environment:
- MINIO_ROOT_USER: minioadmin
- MINIO_ROOT_PASSWORD: minioadmin
+ MINIO_ROOT_USER: ${S3_ACCESS_KEY:-polarisadmin}
+ MINIO_ROOT_PASSWORD: ${S3_SECRET_KEY:-polarisadmin}
command: server /data --console-address ":9001"
healthcheck:
- test: ["CMD", "mc", "ready", "local"]
+ test: ["CMD-SHELL", "mc ready local"]
+ interval: 5s
+ timeout: 5s
+ retries: 5
+ rustfs:
+ image: rustfs/rustfs:1.0.0-beta.2
+ profiles: ["rustfs"]
+ ports:
+ - "9000:9000"
+ - "9001:9001"
+ networks:
+ default:
+ aliases:
+ - s3.local
+ environment:
+ RUSTFS_ACCESS_KEY: ${S3_ACCESS_KEY:-polarisadmin}
+ RUSTFS_SECRET_KEY: ${S3_SECRET_KEY:-polarisadmin}
+ healthcheck:
+ test: ["CMD-SHELL", "curl --fail http://localhost:9000/health";]
Review Comment:
Thanks for the quick review. Yes, this is the first version of rustfs that
actually works with polaris when using complex IAM policies.
In case interested, see more details in
https://github.com/rustfs/rustfs/issues/2699 and
https://github.com/rustfs/rustfs/issues/2766
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
