Y-Wakuta commented on code in PR #4281:
URL: https://github.com/apache/polaris/pull/4281#discussion_r3354007199
##########
runtime/service/build.gradle.kts:
##########
@@ -208,6 +206,15 @@ dependencies {
tasks.named("javadoc") { dependsOn("jandex") }
+// The MySQL JDBC driver is added unconditionally to the integration-test
runner so the
+// `*Mysql*IT` tests run on every CI build. `runtime/service` is not a
distributed artifact,
+// so bundling the GPL driver here has no licensing implication for official
Polaris
+// release artifacts (the production runner in `runtime/server` keeps the
driver opt-in).
+dependencies { runtimeOnly("io.quarkus:quarkus-jdbc-mysql") }
Review Comment:
Good point. With the MySQL test setup moved into the new module (see the
runtime/server thread), the driver dependency is no longer in runtime/service
at all, so this is resolved by that relocation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
