Y-Wakuta commented on PR #4281: URL: https://github.com/apache/polaris/pull/4281#issuecomment-4622528500
@snazy Thank you for the careful review — this is exactly the kind of release/licensing scrutiny this change needed, and I appreciate you laying out each concern so clearly. The Gradle wiring has been restructured since the revision you looked at, largely along the lines you and @dimas-b suggested. Let me walk through each point with the current state. 1. quarkus-jdbc-mysql on :polaris-runtime-service:runtimeClasspath Agreed this must not leak onto a production-facing classpath. runtime/service no longer references the MySQL driver at all. The MySQL integration tests and their driver now live in a dedicated, test-only module (persistence/relational-jdbc-mysql/tests) that builds its own Quarkus server — the same pattern as extensions/auth/opa/tests. That module is not published, so mysql-connector-j stays off runtime-service's classpath and away from any downstream consumer. The default release build is GPL-free with no classpath exclusions. 2. quarkus.datasource.mysql.jdbc=true on the normal service build This is no longer set in runtime/service. It now applies only in runtime/server under the opt-in -PincludeMysqlDriver=true path (and inside the test-only module). The normal/release service build does not set it. 3. License handling in runtime/server The wholesale disabling is gone — no license tasks are disabled anymore. The default build runs generateLicenseReport / checkLicense / licenseReportZip unchanged and stays GPL-free. Under -PincludeMysqlDriver=true the build only adds the driver; the license tasks are intentionally left to fail (documented as a "verification contract"), rather than being silenced, since that flag produces a non-official downstream artifact. If you'd prefer something more targeted here — e.g. the opt-in path producing a correct license listing that includes the GPL driver rather than failing — I'm glad to take that direction; I'd value your preference on what's most appropriate for the project. 4. README placement Agreed — this isn't normal server documentation. The detailed build/config/bootstrap instructions have moved to separate JDBC/MySQL documentation at persistence/relational-jdbc/MYSQL.md, and runtime/server/README.md now only carries a short pointer to it, framed as an opt-in source build. The versioned site docs keep just a one-paragraph note pointing to that source-tree document, consistent with your earlier framing feedback. Since these changes landed after your review, a fresh look whenever you have time would be very welcome. Thank you again for the thorough feedback. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
