Y-Wakuta commented on PR #4281: URL: https://github.com/apache/polaris/pull/4281#issuecomment-4698800757
Hi @jbonofre — gentle reminder when you have a moment 🙏 I believe your points are addressed: - No separate runtime/server-mysql — removed. The MySQL driver is opt-in on the regular runtime/server via -PincludeMysqlDriver=true; the default build stays GPL-free. - db-kind resolved at runtime — the named MySQL datasource is inactive by default and selected at runtime in JdbcMetaStoreManagerFactory, leaving PostgreSQL/CockroachDB/H2 untouched. - Custom build documented — in runtime/server/README.md and persistence/relational-jdbc/MYSQL.md. I've also updated the PR description to match the implementation, and the MySQL integration tests pass. I think the change now meets the requirements we discussed — could you take another look when convenient? Happy to adjust anything further. Thanks again for the detailed review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
