Y-Wakuta commented on code in PR #4281:
URL: https://github.com/apache/polaris/pull/4281#discussion_r3354009053
##########
runtime/service/build.gradle.kts:
##########
@@ -208,6 +206,15 @@ dependencies {
tasks.named("javadoc") { dependsOn("jandex") }
+// The MySQL JDBC driver is added unconditionally to the integration-test
runner so the
+// `*Mysql*IT` tests run on every CI build. `runtime/service` is not a
distributed artifact,
+// so bundling the GPL driver here has no licensing implication for official
Polaris
+// release artifacts (the production runner in `runtime/server` keeps the
driver opt-in).
+dependencies { runtimeOnly("io.quarkus:quarkus-jdbc-mysql") }
+// Override the `jdbc=false` default in `application.properties` so Quarkus
wires up
+// the MySQL named datasource at build time.
+quarkus { quarkusBuildProperties.put("quarkus.datasource.mysql.jdbc", "true") }
Review Comment:
Good question. both are actually needed: jdbc=true is the build-time switch
and active=true is the runtime one, so it's not the same property. This line
has since moved into the new test module along with the　relocation in the
runtime/server thread.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
