cobed95 commented on code in PR #4945: URL: https://github.com/apache/polaris/pull/4945#discussion_r3510364163
########## helm/polaris/values.yaml: ########## @@ -922,6 +922,11 @@ persistence: type: in-memory # relational-jdbc, nosql # The configuration for the relational-jdbc persistence manager. relationalJdbc: + # -- The database schema (namespace) holding the Polaris tables. When empty, Polaris uses the + # default schema `POLARIS_SCHEMA`. Must be a valid SQL identifier: it must start with a letter or + # underscore and contain only letters, digits, and underscores. + # @section -- Persistence + schemaName: "" Review Comment: I agree. Although the empty string would still resolve to the default `POLARIS_SCHEMA` at the code level, it would be much more straightforward for users to see the explicit default value in the helm chart values. I will fix this one first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
