cobed95 commented on PR #4945: URL: https://github.com/apache/polaris/pull/4945#issuecomment-4922622698
Hi Alex — since the proposals above have been sitting for a few days, I went ahead and implemented them so there's something concrete to evaluate. I hope that's alright; nothing here is meant to preempt the open discussions, and I'm very happy to revise or revert any part of it. The changes are split into one commit per review thread: - 21952d59b — Helm chart defaults `schemaName` to `POLARIS_SCHEMA` - 1ec77a3fc — session schema selected on every borrowed connection; `QueryGenerator` back to a static, schema-agnostic utility - 3cb5eb7ef — bootstrap scripts become pure schema-agnostic DDL; schema created programmatically - 1ed89f430 — `@Pattern` bean validation on the config property - 40ba1f142 — docs for identifier case folding and required privileges (the unquoted-behavior proposal) Each commit passes the module tests individually, and the Postgres Testcontainers ITs pass against the final state. I've updated the PR description to reflect the new design, and I'll keep the PR in draft until the open threads are settled. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
