flyrain commented on code in PR #4945: URL: https://github.com/apache/polaris/pull/4945#discussion_r3562576450
########## persistence/relational-jdbc/src/main/resources/postgres/schema-v2.sql: ########## @@ -20,8 +20,6 @@ -- * Added a `location` column to entities -- * Added an index `idx_locations` over (realm_id, parent_id, location) in entities -CREATE SCHEMA IF NOT EXISTS POLARIS_SCHEMA; -SET search_path TO POLARIS_SCHEMA; Review Comment: I don't think we need to change any old schema. We have discussed in a dev mailing thread about only keeping the latest version while releasing a new Polaris version, cc @dimas-b . There is an implicit minor behavior change we will need to apply, which is to remove this parameter for the `bootstrap` command , `-v, --schema-version=<schema version>`, https://polaris.apache.org/releases/1.6.0/admin-tool/#bootstrapping-realms-and-principal-credentials. This parameter allows users to bootstrap a realm with a historical schema. It might be useful for rare use cases, but not worth to do so. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
