cobed95 commented on code in PR #4945: URL: https://github.com/apache/polaris/pull/4945#discussion_r3563793971
########## persistence/relational-jdbc/src/main/resources/postgres/schema-v2.sql: ########## @@ -20,8 +20,6 @@ -- * Added a `location` column to entities -- * Added an index `idx_locations` over (realm_id, parent_id, location) in entities -CREATE SCHEMA IF NOT EXISTS POLARIS_SCHEMA; -SET search_path TO POLARIS_SCHEMA; Review Comment: Hi @flyrain, thanks for the review! I've replied to the dev mailing list that since the removal of `--schema-version` option is a discussion topic on its own, I'm assuming that the removal should be out of scope for this PR. In that case, should we keep the changes to the historical DDL scripts just to let polaris run without errors, and perhaps remove the scripts once `--schema-version` option is removed? Eager to hear your thoughts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
