[
https://issues.apache.org/jira/browse/RATIS-217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16413540#comment-16413540
]
Tsz Wo Nicholas Sze commented on RATIS-217:
-------------------------------------------
[~ljain], thanks for working on this. For the new RpcTimeout, it is more
natural to shutdown the scheduler if there is no tasks (instead of tracking
users). Let's do such improvement later.
Some comments on the patch:
- Remove the initialize parameter from the RpcTimeout constructor. Just call
addUser.
- The rpcTimeout for GRpcLogAppender should be conf value in
RaftServerImpl.getProperties(). Since we have not added the conf yet, let's
move the static rpcTimeout from GrpcFactory to GRpcLogAppender.
- Question: why try-catch handleReplyFuture in RaftClientProtocolClient.
Similarly, why try-catch the code in GRpcLogAppender.timeoutAppendRequest?
> Support timeout for append entry requests(GrpcLogAppender)
> ----------------------------------------------------------
>
> Key: RATIS-217
> URL: https://issues.apache.org/jira/browse/RATIS-217
> Project: Ratis
> Issue Type: New Feature
> Reporter: Lokesh Jain
> Assignee: Lokesh Jain
> Priority: Major
> Attachments: RATIS-217.001.patch
>
>
> This jira aims to add timeout for append entry requests sent by
> GrpcLogAppender.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
