[ 
https://issues.apache.org/jira/browse/RATIS-217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16428180#comment-16428180
 ] 

Tsz Wo Nicholas Sze commented on RATIS-217:
-------------------------------------------

- If callId == -1, wrapException(..) won't put it to the trailers.  What will 
getCallId(..) return in such case?

- Let's skip the following unrelated improvement in this patch although it 
looks correct.  We should do it in a separated JIRA and add some tests for it.
{code}
+      if (request.hasPreviousLog() && follower.getMatchIndex() < 
replyNextIndex - 1) {
+        follower.updateMatchIndex(replyNextIndex - 1);
+        submitEventOnSuccessAppend();
+      }
{code}



> Support timeout for append entry requests(GrpcLogAppender)
> ----------------------------------------------------------
>
>                 Key: RATIS-217
>                 URL: https://issues.apache.org/jira/browse/RATIS-217
>             Project: Ratis
>          Issue Type: New Feature
>            Reporter: Lokesh Jain
>            Assignee: Lokesh Jain
>            Priority: Major
>         Attachments: RATIS-217.003.patch
>
>
> This jira aims to add timeout for append entry requests sent by 
> GrpcLogAppender.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to