[
https://issues.apache.org/jira/browse/RATIS-217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16429199#comment-16429199
]
Tsz Wo Nicholas Sze commented on RATIS-217:
-------------------------------------------
Thanks for the update. A few more nites:
- In SimpleStateMachine4Testing, both blockTransaction and blockAppend should
be volatile.
{code:java}
private boolean blockTransaction = false;
+ private boolean blockAppend = false;
{code}
- In testAppendEntriesTimeout, the second waitForLeader and the sleep(1000)
seems unnecessary.
{code}
waitForLeader(cluster);
long time = System.currentTimeMillis();
long waitTime = 5000;
Thread.sleep(1000);
waitForLeader(cluster);
{code}
- The FollowerInfo.getMatchIndex change should be reverted.
> Support timeout for append entry requests(GrpcLogAppender)
> ----------------------------------------------------------
>
> Key: RATIS-217
> URL: https://issues.apache.org/jira/browse/RATIS-217
> Project: Ratis
> Issue Type: New Feature
> Reporter: Lokesh Jain
> Assignee: Lokesh Jain
> Priority: Major
> Attachments: RATIS-217.004.patch
>
>
> This jira aims to add timeout for append entry requests sent by
> GrpcLogAppender.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
