jiayuasu commented on PR #1095: URL: https://github.com/apache/sedona-db/pull/1095#issuecomment-5125698334
Status note on the checks here, since the remaining red one is not from this PR. **All four Linux/macOS wheel jobs now pass** after rebasing onto #1096 (`linux-x86_64`, `linux-arm64`, `macOS-amd64`, `macOS-arm64`), as does `python ubuntu-latest`, which is the job that actually exercises this PR's change — including the new `Install sedonadb-geopandas` and `Run tests (sedonadb-geopandas)` steps. **`windows-x86_64` still fails, for a different and pre-existing reason.** #1096 did fix the rasterio test failure on Windows too; clearing it revealed a second problem underneath that the earlier failure had masked: | Run | Windows result | | --- | --- | | `main`, before #1096 | `pytest ... failed with code 1` (the rasterio test failure) | | this PR, after #1096 | `3210 passed, 2452 skipped`, then `pytest ... failed with code 3221226505` | Every test passes and then the process exits with `3221226505` = `0xC0000409` (`STATUS_STACK_BUFFER_OVERRUN`). The last lines of the log are the final test passing and the summary line, so this looks like a crash during interpreter teardown rather than a test failure — plausibly native-side shutdown (DLL unload ordering or async runtime teardown), though that is a guess from the log alone. Worth flagging because the impact is wider than this PR: `expr` is gated on all four core wheel jobs, so while `windows-x86_64` fails, the `expr`, `zarr`, and (new here) `geopandas` jobs are all skipped, and the nightly extension wheels never publish. One consequence for reviewing this PR: `wheels-geopandas.yml` has therefore never executed — it was skipped both before and after the rebase. Its wiring has been checked statically (artifact names match their producers in `wheels-linux` and `wheels-expr`, both download into a single `prebuilt/` so one `--find-links` resolves both, and the `>=0.4.0a0` floors let the prerelease wheels satisfy the package's dependencies), and the build itself was verified locally (`set_dev_version.py` → `0.4.0-alpha62` → `sedonadb_geopandas-0.4.0a62-py3-none-any.whl`). But the download/install/test sequence in that workflow has not run in CI yet, and will not until the Windows job is green. Happy to leave this as a draft until then if that is preferred. I have not filed an issue for the Windows crash, since the native/Windows side is better judged by whoever owns it — glad to open one with this evidence if that is useful. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
