jiayuasu commented on code in PR #1095: URL: https://github.com/apache/sedona-db/pull/1095#discussion_r3737709972
########## python/sedonadb-geopandas/pyproject.toml: ########## @@ -21,13 +21,18 @@ build-backend = "hatchling.build" [project] name = "sedonadb-geopandas" -version = "0.4.0" description = "GeoPandas-compatible API on top of SedonaDB" readme = "README.md" requires-python = ">=3.9" +dynamic = ["version"] dependencies = [ - "sedonadb", - "sedonadb-expr", + # The `.geo` accessor and `DataFrame.unnest` this package builds on landed in + # 0.4.0. The floor is an explicit prerelease (`0.4.0a0`) so dev/nightly + # builds — which version as `0.4.0aN` and are PEP 440-*less* than `0.4.0` — + # satisfy it; a plain `>=0.4.0` would reject the matching nightly wheels + # (and break `pip install` of the nightly for users, not just CI). + "sedonadb>=0.4.0a0", + "sedonadb-expr>=0.4.0a0", Review Comment: Changed to `>=0.4.0`, thanks — that is simpler and it does hold now. Recording the reasoning, since the two facts look contradictory at first: the prerelease floor was doing real work when it was written, because the workspace was on 0.4.0 at the time, so nightlies versioned as `0.4.0aN`, and PEP 440 orders `0.4.0a62` *below* `0.4.0` — a plain `>=0.4.0` rejected exactly the nightly wheel it was paired with (the same trap `sedonadb-zarr` documents). The workspace has since moved to 0.5.0, so nightlies are `0.5.0aN`, which satisfies `>=0.4.0` fine, and that stays true for later cycles. The condition is therefore "the floor must be a released version, not the version currently being developed", so I kept a short comment to that effect rather than the prerelease pin — otherwise someone raising the floor to match the dev line would silently reintroduce it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
