jiayuasu commented on PR #1095:
URL: https://github.com/apache/sedona-db/pull/1095#issuecomment-5213135379
Taking this out of draft. Status update, since the situation changed with
the recent wheel-build work and my earlier comment above is now out of date.
Rebased onto current `main`, which includes #1100 and #1111. #1111 is the
relevant one here: adding `if: ${{ !cancelled() }}` to the extension jobs means
a failing platform no longer skips them, so the new `geopandas` job is finally
reachable and `wheels-geopandas.yml` is being exercised for the first time in
the run on this commit.
On the gating: the `geopandas` job deliberately keeps a plain `needs:
["expr"]` rather than also taking `if: ${{ !cancelled() }}`. It downloads the
`release-expr-wheels` artifact, and `wheels-expr.yml` uploads that artifact
after its test step — so if `expr` fails there is no artifact to download, and
running anyway would just produce a confusing download failure. Requiring
`expr` to succeed is the accurate condition for this job; the `!cancelled()` on
`expr` itself is what decouples it from a failing platform.
Two notes for review:
- `python ubuntu-latest` passes, including the new `Install
sedonadb-geopandas` and `Run tests (sedonadb-geopandas)` steps. Any red
wheel-platform checks here are wheel-build issues unrelated to this PR and are
being addressed separately, so this PR is not trying to fix them.
- The workspace version moved from 0.4.0 to 0.5.0 while this was open, which
incidentally exercised the versioning change in this PR: because the package
now derives its version from the workspace `Cargo.toml`, it reports 0.5.0
automatically. The hard-coded `version = "0.4.0"` it replaced would be wrong as
of that bump. The dependency floors stay at `>=0.4.0a0`, since they record the
minimum version providing the `.geo` accessor and `DataFrame.unnest`, and 0.5.0
satisfies them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
